Score Minimum Value #1046
Merged
Score Minimum Value #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samuel-Roach
force-pushed
the
mercy-limit-min
branch
from
f1ce1c7
to
1501658
Compare
|
For testing i recommend the |
|
Given that this new min may only ever have an effect if a mercy rule is defined, how about: <score>
<limit>10</limit>
<mercy min="5">2</mercy>
</score>This would make the max-score start at 5, go at most up to 10, and be always 2-higher than the runner-up |
|
Makes sense given the dependency on mercy rule. I'll make the change |
Signed-off-by: Samuel Roach <[email protected]>
Signed-off-by: Samuel Roach <[email protected]>
Signed-off-by: Samuel Roach <[email protected]>
Signed-off-by: Pablete1234 <[email protected]> Signed-off-by: Samuel Roach <[email protected]>
Signed-off-by: Pablete1234 <[email protected]> Signed-off-by: Samuel Roach <[email protected]>
Signed-off-by: Pablete1234 <[email protected]> Signed-off-by: Samuel Roach <[email protected]>
Signed-off-by: Pablete1234 <[email protected]> Signed-off-by: Samuel Roach <[email protected]>
Signed-off-by: applenick <[email protected]> Signed-off-by: Samuel Roach <[email protected]>
Samuel-Roach
force-pushed
the
mercy-limit-min
branch
from
ea42396
to
75bf28c
Compare
Signed-off-by: Samuel Roach <[email protected]>
Pablete1234
reviewed
Sep 6, 2022
Comment on lines
104
to
108
| List<Element> mercyElements = scoreEl.getChildren("mercy"); | ||
| for (Element mercyEl : mercyElements) { | ||
| config.mercyLimitMin = | ||
| XMLUtils.parseNumber(Node.fromAttr(mercyEl, "min"), Integer.class, -1); | ||
| } |
There was a problem hiding this comment.
I suggest using XMLUtils.getUniqueChild for this, not iterating a list
Electroid
force-pushed
the
dev
branch
2 times, most recently
from
20c50fe
to
d978236
Compare
Signed-off-by: Samuel Roach <[email protected]>
|
Sorry this took a while. Finally got around to using |
Pablete1234
approved these changes
Oct 22, 2022
Electroid
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes to reflect the change suggested in #1024 (comment).
Adds
mercyLimitMinto ScoreConfig to store the minimum score required for a MercyRule to enforce.Mercy Rule now calculates a
mercyBaselinewhich will be the maximum of themercyLimitMinandscoreBaseline + mercyLimit.This hasn't been tested, although linting and building works. Sidenote: I could use some help with setting up a local PGM server such that I can test changes.